remove Tab.TabContent.url #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
github-actions
bot
removed
the
bot: not in app board
tomasstrba
reviewed
Apr 19, 2024
DuckDuckGo/Fireproofing/Extensions/FireproofingURLExtensions.swift
Outdated
Show resolved
Hide resolved
|
|
||
| /// user-editable URL displayed in the address bar |
There was a problem hiding this comment.
Should we rename it to urlForAddressBar? 🤷 Not a strong opinion.
There was a problem hiding this comment.
I don‘t know, I think user editable url is pretty expressive to keep it
| let urlScheme = tabViewModel.tab.content.url?.scheme | ||
| let isHypertextUrl = urlScheme == "http" || urlScheme == "https" | ||
| let isHypertextUrl = if case .url(let url, _, _) = tabViewModel.tab.content, | ||
| !(url.isDuckPlayer || url.isDuckURLScheme), |
There was a problem hiding this comment.
I wonder if a computed property for this condition would make sense for reuse in future since these URLs will always have a special treatment.
There was a problem hiding this comment.
refined it a little bit for more clarity
tomasstrba
reviewed
Apr 23, 2024
| @@ -30,6 +30,11 @@ extension URL.NavigationalScheme { | |||
| return [.http, .https, .file] | |||
| } | |||
|
|
|||
| /// HTTP or HTTPS | |||
| var isHypertextScheme: Bool { | |||
| let urlScheme = tabViewModel.tab.content.url?.scheme | ||
| let isHypertextUrl = urlScheme == "http" || urlScheme == "https" | ||
| let isHypertextUrl = if case .url(let url, _, _) = tabViewModel.tab.content, | ||
| !(url.isDuckPlayer || url.isDuckURLScheme), |
|
Actually it seems we're allowing to bookmark any url, see the design review |
|
I‘ve fixed opening |
samsymons
added a commit
that referenced
this pull request
Apr 26, 2024
…utdown # By Dax the Duck (9) and others # Via GitHub (6) and others * main: (47 commits) Update BSK to 141.1.1 (#2713) macOS: VPN Metadata Improvements (#2704) duck page suggestions (#2666) macOS: Add pixels to track VPN wake and stop attempts (#2694) Trusted url indicator (#2665) remove Tab.TabContent.url (#2647) Bump version to 1.85.0 (176) Update release automation to support Privacy Pro section in release notes (#2710) Fix for VPN stop issues. (#2689) Hard-codes the VPN waitlist flags to ON (#2709) Add subscription status to the macOS metadata (#2680) Bump version to 1.85.0 (175) Call finish in the correct place (#2702) Fix layout issue on DBP (#2700) Update autoconsent to v10.6.1 (#2618) Make Clear All History shortcut available without entering Main Menu (#2682) Fix DataBrokerProtectionProcessor.swift lint Fix SwiftLint Add parameter allowed encoding to error descriptions (#2691) Remove debug flags ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207078384259685/f
Description:
urlForWebViewanduserEditableUrlSteps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation